microsoft/Terminal

Bug Report: ConHost Caption BoundingRects dissapeared

Open

#2,176 opened on Jul 31, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-AccessibilityHelp WantedIssue-BugPriority-2Product-Conhost

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Environment

Caused by Accessibility PR: https://github.com/microsoft/terminal/commit/96496d8154113ae9e0bcbe47b4bbaf33a0d4e961

Steps to reproduce

  1. open ConHost
  2. open inspect.exe
  3. find caption buttons

Expected behavior

bounding rects should appear over caption buttons

Actual behavior

bounding rects aren't there. But it seems like you can interact with them perfectly fine otherwise.

Other notes

I think the main culprit here is WindowUiaProvider. Not entirely sure what caused it though.

Contributor guide

Research direction
Examine the changes in commit 96496d8154113ae9e0bcbe47b4bbaf33a0d4e961, particularly in WindowUiaProvider, to identify why bounding rects for caption buttons disappeared. Use tools like inspect.exe to verify.
Tech stack
cpp
Domain
accessibilitydesktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70