microsoft/Terminal

Only regenerate our .metaproj when the .sln changes

Open

#2,172 opened on Jul 31, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-BuildHelp WantedIssue-TaskProduct-Meta

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

From #2168.

This change could use some extra love - generating the metaproj takes a little while, as does parsing it. There might be a way to only generate the metaproj if it's changed, I didn't really investigate this, but presumably it could be done with a powershell script. I'll leave that for another work item in the future.

This is that future work item

Contributor guide

Research direction
Investigate the build process to find where the .metaproj file is generated. Determine how to detect changes to the .sln file and conditionally regenerate the .metaproj only when changes occur.
Tech stack
cpp
Domain
build system
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++PowerShellVisual Studio solution files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30