microsoft/Terminal

Don't resize the terminal buffer until dragging is released

Open

#2,140 opened on Jul 29, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-FeatureProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Add a setting to enable this behavior.

Maybe the user might not want to reflow the buffer in real-time as they resize the window. Maybe they only want to have the resize occur when they finish resizing.

I'd love to see an E2E spec of this scenario before code starts getting written, because I feel it might be a little wonky in certain scenarios. Questions that would be good to be answered:

  • How will we communicate the start of a move/size loop from WindowsTerminal down to the TerminalApp?
  • How will this play with panes that aren't terminals?
  • how do we handle maximize/restore?
  • Should we pause rendering while this is happening? How should this look to the user?

From discussion in #1465

Contributor guide

Research direction
Investigate how to propagate resize start and end events from the WindowsTerminal window to the TerminalApp and implement a setting to defer buffer reflow until the resize action is completed.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Windows App Development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50