microsoft/Terminal

Make sure MinMaxCloseControl supports FullScreen & Tablet Mode

Open

#2,001 opened on Jul 17, 2019

View on GitHub
 (2 comments) (5 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Some thoughts about the Min/Max/Close buttons, and supporting FullScreen or Tablet Mode

Some properties to consider for this TitlebarControl. This could be also be useful for the Settings UI, if it is presented in a window.

  • CanMaximise
  • CanMinimise
  • CanRestore

Which would hide those buttons if you wanted to make a settings screen which only shows a close button. Also consider how these TitleBar Controls will handle FullScreen/Tablet Mode

image Full Screen

Screenshot (17) Tablet Mode

Originally posted by @mdtauk in https://github.com/microsoft/terminal/pull/1948#issuecomment-512048300

Contributor guide

Research direction
Investigate how FullScreen and Tablet Mode are detected in the Windows Terminal and understand the existing MinMaxCloseControl implementation to add support for these modes.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35