microsoft/Terminal

Terminal Crashes when Reopening closed settings window

Open

#18,509 opened on Feb 5, 2025

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-QualityHelp WantedIssue-BugNeeds-AttentionProduct-TerminalSeverity-Crash

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.21.10351.0

Windows build number

10.0.26100 Build 26100

Other Software

No response

Steps to reproduce

Open the settings pane and then close it, reopen it using the "Restore the last closed pane or tab" shortcut, then close it again and reopen it. Upon trying to reopen the tab the second time, the terminal crashes

https://github.com/user-attachments/assets/dfdd595f-2318-4ac3-a89e-c48db6a3d7c6

Expected Behavior

The settings pane should open again instead of crashing

Actual Behavior

Windows Terminal Crashes on reopening the closed settings pane the second time

Contributor guide

Research direction
Investigate the settings pane lifecycle. The crash occurs upon reopening the settings pane for the second time after closing. Check the pane's destructor and restore logic, ensuring that the created pane is properly initialized and that references are not dangling.
Tech stack
cpp
Domain
desktopcli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50