microsoft/Terminal

How to avoid changing cursorShape when focus terminal window if I set `unfocusedAppearance`

Open

#18,174 opened on Nov 11, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-TerminalControlHelp WantedIssue-BugProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.21.2911.0

Windows build number

10.0.22631.0

Other Software

NVIM v0.10.2

Steps to reproduce

  1. snippet in settings.json
 "opacity": 50,
 "cursorShape": "underscore",
 "unfocusedAppearance": {
      "opacity": 90
 },
  1. open nvim, current cursor shape is block
  2. press alt+tab to focus another window, then press it again to focus back to terminal
  3. cursor shape changes to underscore. (If I delete the unfocusedAppearance in settings.json, the cursor shape does not change after focus back)

Expected Behavior

When I set unfocusedAppearance, do not change my cursor shape after focus back to terminal window.

Actual Behavior

Cursor shape changes to underscore that I set in cursorShape.

Contributor guide

Research direction
Investigate the code path for `unfocusedAppearance` and how cursor shape is restored when focus returns. Look for missing preservation of cursor shape state when `unfocusedAppearance` is applied.
Tech stack
cpp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65