microsoft/Terminal

Windows key doesn't work when assigning key actions

Open

#17,437 opened on Jun 17, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsUIHelp WantedIssue-BugNeeds-Tag-Fix

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.20.11381.0

Windows build number

10.0.22621.3737

Other Software

No response

Steps to reproduce

Go to settings --> actions --> any action and try to set the key combination. Any combination that involves the windows key is not recognized. This is new with a recent version of terminal.

Expected Behavior

Windows key should be allowed in actions key combinations.

Actual Behavior

The key command does not change. It only changes if the windows key is not involved in the input.

Contributor guide

Research direction
Investigate the key binding input handler in Windows Terminal, specifically how the Windows key is processed during key combination assignment. Look for recent changes that may have broken recognition of the Windows key modifier.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55