microsoft/Terminal

Re-enable support for DECKPAM

Open

#16,672 opened on Feb 6, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-InputArea-VTHelp WantedIn-PRIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

This was originally tracked in #16506. Support was added in #16511. But turns out people didn't expect the Terminal to actually be like, compliant: #16654

So now we're gonna add a setting to be able to manually enable/disable support for toggling this mode.

The trick here? ConPTY is the thing that's going to need to do the input translation, not the Terminal. So, the Terminal needs a way to tell conpty (at runtime)1 if this is a mode that's allowed or not. And that, we don't have a good system set up for currently.

Footnotes

  1. Leonard keeps terrifyingly calling this ConPTY IOCTL ↩

Contributor guide

Research direction
Investigate how ConPTY does input translation and design an IOCTL mechanism for the Terminal to toggle DECKPAM support at runtime.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows TerminalConPTY
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30