microsoft/Terminal

Cursor width should respect dpi settings

Open

#16,228 opened on Oct 25, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-AtlasEngineArea-TerminalControlHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.18.2822.0

Windows build number

10.0.22621.0

Other Software

None

Steps to reproduce

Set display scale to 200% and use the bar cursor.

Expected Behavior

Cursor width should respect dpi settings.

Actual Behavior

On 200% scale monitor, drawing the bar shape cursor use native 1px, not 1 logical pixel (2px). This makes it a little hard to locate, especially in light theme.

screenshots: terminal, WinUI control, browser

screenshots

Contributor guide

Research direction
Investigate how cursor width is calculated in the rendering pipeline and ensure it uses logical pixels scaled by DPI settings.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++Windows development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60