microsoft/Terminal

Wrap double-height text properly

Open

#15,681 opened on Jul 9, 2023

View on GitHub
 (9 comments) (1 reaction) (0 assignees)C++ (3,212 forks)batch import
Area-OutputHelp WantedIssue-TaskProduct-Conhost

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

Create double-height text and then use it to write a line longer than the width of the current console window/pane

Expected Behavior

that it would wrap into another double-height line

Actual Behavior

It actually breaks the double-height line into two and ruins the effect, and then wraps the remainder twice as single height lines

image

Perhaps the wrapped text of a "big" line can be buffered and if it matches the wrapped text of the next line and that line is also "big", then a new "big" line can be created with the wrapped text and inserted after?

Contributor guide

Research direction
Investigate the text wrapping logic in the terminal renderer, focusing on how double height lines are handled. Look at the code that handles line wrapping and text layout, particularly in the conhost or renderer components.
Tech stack
None
Domain
desktopcli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60