microsoft/Terminal

Windows Terminal Icon Issue.

Open

#15,429 opened on May 25, 2023

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.16.10262.0

Windows build number

10.0.22621.1702

Other Software

No response

Steps to reproduce

Just change the theme of Windows to dark and then again to light.

Expected Behavior

Windows Terminal icon pinnned in desktop will change as per the theme.

image

Actual Behavior

It should change as per theme

https://github.com/microsoft/terminal/assets/75790404/0b4d9d2e-c3a5-4175-8dd2-132ad78f0274

Contributor guide

Research direction
Look at how Windows Terminal updates its icon when the Windows theme changes. Focus on the code that handles theme change events and the icon resource loading. Check if the icon is being updated dynamically or statically. Test by forcing a theme change in debug mode and tracing the icon refresh path.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75