microsoft/Terminal

Drop-down options in Settings always follow system theme

Open

#15,428 opened on May 25, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsUIHelp WantedIssue-BugProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.18.1421.0

Windows build number

10.0.22621.1702

Other Software

No response

Steps to reproduce

  1. set the WT theme to be the opposite of your system theme. In my case, system theme is light but Terminal is set to dark.
  2. open Settings
  3. click any option that has a drop-down.

Expected Behavior

The application theme is followed, in my case dark.

Actual Behavior

The system theme is followed, in my case light (on the right is the Settings app showing that my system theme is light.)

Contributor guide

Research direction
Investigate how the application theme is applied to ComboBox dropdowns in Settings. Check if the theme resource is properly overridden for the popup part.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++WinUI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60