microsoft/Terminal

Settings UI: Check that the starting directory is normalized

Open

#15,093 opened on Apr 3, 2023

View on GitHub
 (13 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-TerminalConnectionHelp WantedIssue-BugProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.16.10262.0

Windows build number

10.0.22000.1696

Other Software

No response

Steps to reproduce

  • create a new profile
    • Command line - > cmd.exe
    • "Starting directory" -? enter an existing path using a lower case drive letter (e.g. c:\users)
  • start a new terminal session with the new profile

Expected Behavior

cmd.exe is started in C:\Users as drive letters are upper case and NTFS is by default case preserving.

in the case where NTFS was set to be case sensitive then I would expect cmd.exe to be started in C:\users as the drive letters are always case insensitive and canonically upper case.

Actual Behavior

the CWD is exactly as entered (all lower case)

This causes some subtle issues with some programs / developer environments where tests are asserting that some log was written containing a canonicalized path.

(also this is half way between an issue and a new feature :) )

Contributor guide

Research direction
Investigate the settings UI code that handles the starting directory input, and add normalization to uppercase the drive letter before storing or using the path.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows Terminal development environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40