microsoft/Terminal

Our MinMaxCloseControl's resources are all messed up

Open

#14,951 opened on Mar 3, 2023

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-i18nHelp WantedIssue-BugIssue-TaskNeeds-Tag-FixPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.16.10262.0

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

Hover the center of the windows' close button.

Expected Behavior

A tooltip should appear in the local language's equivalent of "Close".

Actual Behavior

Hovering the button shows two tooltips fade in, first the English one, then the local language's one.

image

https://user-images.githubusercontent.com/24683548/222845299-ac3d37c1-e5fb-4a34-997a-f71d086ca9cd.mp4

Contributor guide

Research direction
Investigate the tooltip loading mechanism for the MinMaxCloseControl. Check if there are duplicate resource loads or timing issues causing both default and localized tooltips to appear. Look at how the tooltip text is set and if there is a race condition.
Tech stack
None
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50