microsoft/Terminal

Followups from the new C++/WinRT

Open

#14,872 opened on Feb 18, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Meta

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Interesting things we could do after #14869 landed:

### Tasks
- [x] remove all `InitializeComponent` calls - they do it automatically
- [ ] use `std::optional`<->`IReference` automatic binding
- [x] use `std::format` support (!) for json/uri/hostname/http stuff/all `IStringable`s
- [ ] potentially move to `/await:strict` for C++20 coroutines

Contributor guide

Research direction
Examine methods that return Windows::Foundation::IReference<T>. Change them to return std::optional<T>. Ensure that the automatic binding between std::optional and IReference works in C++/WinRT by including <winrt/Windows.Foundation.h> or the appropriate headers. Update any callers that expect IReference to use std::optional. Test compilation and behavior.
Tech stack
cpp
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++C++/WinRT
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60