microsoft/Terminal

`tab.showCloseButton: hover|never` + `tabWidthMode: titleLength` should have some padding on the left of the tab

Open

#13,725 opened on Aug 11, 2022

View on GitHub
 (4 comments) (1 reaction) (0 assignees)C++ (3,212 forks)batch import
Area-ThemingHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

  • There should be a bit more space to the right of the tab title to match the left side (next to icon) image

From 1.16.2142.0 bash on Aug 2nd

  • Gap between inactive tabs and content image
  • A light tabRow.BG in dark mode causes the chevron to be white: image
    • fixed in #13871
  • We need to remove useMica
  • With "tab.background" set to "terminalBackground":
    • Hover over a terminal tab -> the tab color doesn't change/give any visual feedback that it is being hovered over
    • Hover over a settings tab -> the tab color does change/give visual feedback

additional

  • With "tab.showCloseButton" set to "hover": Height of inactive tabs change upon hover - (can't seem to post a GIF in OneNote so try it yourself)
    • Mike couldn't repro this, so maybe someone else can?

Contributor guide

Research direction
Inspect the XAML layout for tab items, specifically the padding around the title when showCloseButton is set to hover or never and tabWidthMode is titleLength. Look for how the close button visibility affects the title placement.
Tech stack
cpp
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75