microsoft/Terminal

Support multiple pixel shaders to be applied on the terminal texture buffer

Open

#13,568 opened on Jul 22, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-RenderingHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Allow multiple pixel shaders to be specified

Current configuration allows the user to specify a single pixel shader. It'd be useful if the parameter could be a list of shaders to be applied in order, for instance, distorting the screen to make it match a CRT tube (could be be even specified as two shaders, one for horizontal curvature that, if applied alone, would simulate a Trinitron tube, and other for the vertical curvature) and another to simulate raster artifacts.

Proposed technical implementation details (optional)

I'd keep the current syntax that accepts a single string for single shaders, and also accept a list of strings for multiple shaders to be applied in order.

Contributor guide

Research direction
Examine the current shader loading code in the Terminal renderer and modify it to accept an array of shader paths, then apply them sequentially.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40