microsoft/Terminal

Tab drag causes mousedown in tmux

Open

#13,191 opened on May 27, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-InputArea-TerminalControlHelp WantedIssue-BugPriority-2Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.13.11432.0

Windows build number

10.0.22000.0

Other Software

tmux 3.0a inside WSL2

Steps to reproduce

  • Open a tmux session inside WSL2 (Ubuntu 20.04.3 in my case)
  • Drag the current tab downwards so it overlays the screen area (and do it quite fast)

Expected Behavior

The tmux session should be unaffected by the drag action outside of it.

Actual Behavior

Onmousedown / drag apparently is triggered and causes the selection to change and scroll mode to start. This only happens if you drag quite fast.

https://user-images.githubusercontent.com/5270359/170699426-7528dbdd-d5cc-4ddd-9ffc-b82d7630a4ac.mp4

The latest preview version 1.14.1452.0 also has this issue and 1.12 had it as well.

Contributor guide

Research direction
Investigate the mouse event handling when dragging the tab over the terminal area. Look at the code that handles mouse input and tab drag to identify why mousedown is triggered.
Tech stack
None
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60