microsoft/Terminal

We don't update LPWINDOWPOS flags during `WM_WINDOWPOSCHANGED`, maybe we should?

Open

#12,924 opened on Apr 18, 2022

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthArea-WindowingHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

https://github.com/microsoft/terminal/blob/41ef5554f5cb946c4a48e2b8db791265c7217fce/src/cascadia/WindowsTerminal/IslandWindow.cpp#L592

Since size is changed here shouldn't we clear the SWP_NOSIZE bit in lpwpos->flags?

Contributor guide

Research direction
Inspect the WM WINDOWPOSCHANGED handler in IslandWindow.cpp and check if SWP NOSIZE flag should be cleared when size changes.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60