microsoft/Terminal

Tab position is not restored for `restoreLastClosed` action

Open

#12,902 opened on Apr 13, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

The problem with this is the tab position is not restored, if tab closed is first one, the restored tab is the last one. the position should also be restored

Originally posted by @swinder0161 in https://github.com/microsoft/terminal/issues/960#issuecomment-1098341305

This might be tricky - we might be able to remember the location of the tab, but I'd expect it to work weird if the tabs get reordered before restoring the tab. This might be acceptable though.

Contributor guide

Research direction
Investigate how the tab state is stored and how the `restoreLastClosed` action retrieves and restores tabs. Look at the tab management code to understand how the tab position is saved and whether it's being used during restoration. Consider the edge case where tabs have been reordered.
Tech stack
None
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25