microsoft/Terminal

globalSummon and multipleActions should be able to be used at the same time

Open

#12,846 opened on Apr 6, 2022

View on GitHub
 (1 comment) (2 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsArea-UserInterfaceHelp WantedIssue-FeatureProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

I'm not sure if this is currently supported so apologies if I filed this incorrectly.

Description of the new feature/enhancement

In settings.json, allow actions in "actions" list to be globalSummon and have multiple actions.

It seems like both "globalSummon" and "multipleActions" go into the "action" field of the "command" object so you can't use both at the same time. But it seems natural to users (also I have a scenario where I would like this to work) that they would want to do globalSummon and then run some actions.

This would allow terminal to take market from autohotkey where users want to register global hotkeys as well but terminal can do something hotkey actions better because terminal can display the output and provide better user interface.

Proposed technical implementation details (optional)

Make globalSummon its own field in "command" that changes how the action keybinding is bound and let multipleActions behave the as it used to.

Contributor guide

Research direction
Examine how the command model handles 'globalSummon' and 'multipleActions' in the settings schema and keybindings code. Look for the relevant code in `src/cascadia/TerminalSettingsModel/` where action parsing and execution occur. Propose a change to separate 'globalSummon' into its own field to allow coexistence with 'multipleActions'.
Tech stack
None
Domain
backenddeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++Windows Terminal development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50