microsoft/Terminal

unfocusedAppearance ignores backgroundImage set to null and continued to display image

Open

#12,643 opened on Mar 8, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsHelp WantedIssue-BugPriority-2Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.13.10395.0

Windows build number

10.0.22567.1

Other Software

No response

Steps to reproduce

It is possible to set in the UI, and via the settings XML, for there to be no background image when a terminal windows is unfocused using the example below: "unfocusedAppearance": { "backgroundImage": null }

Expected Behavior

The expected behaviour is that the background image will disappear when set to null or change image to a new image if a value is set

Actual Behavior

Actual behaviour is that the background image continues to be displayed if set to null, although a new image is displayed if a correct file location is set.

Contributor guide

Research direction
Examine how unfocusedAppearance processes the backgroundImage setting, specifically the null case, by tracing the path from settings parsing to rendering.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70