microsoft/Terminal

Acrylic in Tab Row has a weird blur on the bottom

Open

#12,392 opened on Feb 6, 2022

View on GitHub
 (4 comments) (2 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.13.10336.0

Windows build number

21H2 22000.469

Other Software

With "Show acrylic in tab row" set:

image

The blur isn't rendered consistently when part of the window is not on a monitor:

image

In this example the window is dragged to the right so half of it is not on any monitor. The top part of the title bar blurs the non-existent space as black but the bottom part of the title bar ignores the non-existent space and only blurs the background of the portion of the bar actually on a display(s). Note particularly on the far right of the title bar.

Steps to reproduce

Enable acrylic in tab row -> restart -> drag part of the title bar off the screen. Easiest to see if you have something bright in the background of the window.

Expected Behavior

The top and bottom part of the title bar use the same blurring method.

Actual Behavior

The top and bottom parts of the title bar use different blurring methods.

Contributor guide

Research direction
Investigate the acrylic blur rendering in the tab row, focusing on how the window region is computed when partially off screen. Look at the title bar rendering code and compare top vs bottom blur behavior.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows APIGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60