microsoft/Terminal

Change + icon when hovering it with Alt held, like VS Code

Open

#12,367 opened on Feb 4, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-TaskPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Watch this gif carefully. When the + is hovered with alt held, it changes to a split pane icon:

image

(from https://code.visualstudio.com/updates/v1_57#_terminal-tabs)

We shouldn't change that button every time alt is pressed, just when it's hovered with alt IMO

Contributor guide

Research direction
Investigate the current implementation of the '+' button in the terminal tabs. The button likely uses a custom control or event handler. Look for how the Alt key modifier is detected in hover events. Possibly modify the button's visual state based on the modifier key. Refer to VS Code's implementation for inspiration.
Tech stack
None
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70