microsoft/Terminal

Add icons to new SUI expanders

Open

#12,359 opened on Feb 3, 2022

View on GitHub
 (1 comment) (2 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsUIHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

The new Settings UI in terminal utilizes expanders to group settings controls, which matches up with the other inbox apps shipped in Windows 11. Something that I believe should be added (both for the sake of consistency and visual hierarchy) is expander icons.

At the moment, most inbox apps add an icon prefixed before each settings group that conveys it's semantic meaning. This both looks nice and makes it easier to quickly differentiate between groups.

Current: image

Notepad: image

Clock: image

It's worth noting that not every app does this. For example, Snipping Tool has no icons in it's expanders, although I do still believe this could be an improvement.

Contributor guide

Research direction
Examine the existing expander controls in the Settings UI and identify where icons could be added. Look at how other inbox apps like Notepad and Clock implement expander icons for guidance. The implementation likely involves modifying XAML templates and adding icon resources.
Tech stack
None
Domain
frontenddesktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++XAMLWindows Terminal development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60