microsoft/Terminal

Opening File Explorer using the browse button in settings sometimes gets stuck

Open

#12,199 opened on Jan 19, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsUIHelp WantedIssue-BugNeeds-ReproPriority-2Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.11.3471.0

Windows build number

10.0.19044.1469

Other Software

No response

Steps to reproduce

  1. Press Ctrl + ` to open the settings interface
  2. Click "Add a new profile" to create a new profile
  3. Click the "Browse..." button
  4. The interface freezes. Neither the File Explorer window nor the "Windows Terminal" can be closed via the taskbar

Expected Behavior

Open a file explorer window that works normally, but also can be closed normally

Actual Behavior

The interface is frozen, and the Explorer window for selecting files cannot be manipulated, nor can this window be closed

Contributor guide

Research direction
Investigate why clicking the Browse button causes the UI to freeze. Check if the file dialog is being called on the UI thread and if it should be offloaded to a background thread.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70