microsoft/Terminal

Search is often broken while console process is running

Open

#1,215 opened on Jun 12, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-InteractionHelp WantedIssue-BugPriority-3Product-Conhost

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Environment

Windows build number: 10.0.18362.113
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

have a long running process (e.g. msbuild), and ctrl+F to find something. Often the match will be off by one line 10.0.18362.113

Expected behavior

I can find the text properly

Actual behavior

The text that gets selected when searching is not the right text

Contributor guide

Research direction
Investigate the search highlighting logic and how it interacts with the rendering of the console buffer during updates. Start by finding the code that handles `Ctrl+F` and the selection of matched text. Look for off by one errors in the calculation of line numbers or character positions when a background process is writing to the console.
Tech stack
cpp
Domain
desktopdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++ build tools
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70