microsoft/Terminal

IPv6 links can not be Ctrl+Clicked

Open

#11,901 opened on Dec 8, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C++ (3,212 forks)batch import
Area-TerminalControlHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version

1.12.2931.0

Windows build number

10.0.22000.348

Other Software

No response

Steps to reproduce

  1. Run any command that writes an IPv6 link in the terminal window, for example echo http://[::1]/
  2. Hover over the link, or try to Ctrl+Click it to follow it

Expected Behavior

Hovering over the link should show the underline and the tooltip about Ctrl+Clicking it, and Ctrl+Clicking it should follow the link like any other link.

Actual Behavior

Nothing happens when hovering over the link or Ctrl+Clicking it.

_

Contributor guide

Research direction
Inspect the URL detection logic, specifically the regular expression or parser used for identifying links. Check if IPv6 literals like http://[::1]/ are being correctly handled. Look for where Ctrl+Click is processed and trace the path from the click event to the link detection.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50