microsoft/Terminal

Refactor `_GetProposedFont` into a static function

Open

#11,763 opened on Nov 15, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthArea-PerformanceHelp WantedIssue-TaskPriority-2Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Ported from MSFT-21254947

With Dart/OpenConsole!3129098, I instantiate an entire DxEngine just to get the initial size of the control.

Turns out there's only two things that _GetProposedFont really needs from the instance - the dwriteFactory, and the _chainMode. If we make those params, then we could make GetProposedFont a public static function, and not need to instantiate an entire engine (including all the dx resources it needs) just to get the font size.

We should not be spinning up an entire DX Renderer to ask it how big a cell should be.

Contributor guide

Research direction
Extract the ` GetProposedFont` method to be a static function by passing `dwriteFactory` and ` chainMode` as parameters. Update all callers.
Tech stack
cpp
Domain
None
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70