microsoft/Terminal

The info bar shows up on nonzero exit codes even with ` "closeOnExit": "always"`

Open

#11,608 opened on Oct 25, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-2Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

From @KalleOlaviNiemitalo in https://github.com/microsoft/terminal/issues/10798#issuecomment-950857104

infobar-on-closeonexit-always

This might just go away if we do #11607 first, but it might not. Tracking this separately regardless

Contributor guide

Research direction
Investigate the code path that shows the info bar on nonzero exit codes and check how closeOnExit: 'always' is supposed to suppress it. Look at the logic in the handler where exit codes are processed and the info bar is triggered.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows Terminal codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60