microsoft/Terminal

Closing a pane that summoned the "termination behavior" infobar should probably just dismiss it

Open

#11,607 opened on Oct 25, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

From @KalleOlaviNiemitalo in https://github.com/microsoft/terminal/issues/10798#issuecomment-950857104

I then pressed Ctrl+Shift+W to close the tab, but the info bar remained there.

Contributor guide

Research direction
Investigate the infobar dismissal logic when a pane or tab is closed. Trace the event handling of Ctrl+Shift+W and the associated infobar.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55