microsoft/Terminal

Bug: Quake mode (globalSummon) animation with dropdownDuration=0

Open

#11,381 opened on Sep 30, 2021

View on GitHub
 (4 comments) (3 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-WindowingHelp WantedIssue-BugNeeds-ReproPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

Windows 1909 (build 18363), might be relevant for repro since it's about the actual window.

Steps to reproduce

Add the following action to settings.json under "actions":

{ "keys": "win+`", "command": { "action": "globalSummon", "name": "_quake", "dropdownDuration": 0 } },

First press Win+` to launch the quake window.

Then press it again to hide, and another time to show the quake window, and notice the show/hide animations.

Expected Behavior

Both the hide and show animations should be instant, no animation should play and the window should appear and disappear instantly.

Actual Behavior

The hide animation works as expected, but the show animation is no longer a reveal from above but rather a zoom out and pan (to top left) for some reason.

Changing "dropdownDuration" to 1 instead of 0 works as expected, a workaround.

If it doesn't repro for you, perhaps the Windows version is important.

Contributor guide

Research direction
Examine the animation logic for globalSummon when dropdownDuration is 0. Focus on why the show animation differs from the hide animation. Check the code for window positioning and animation effects.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitWindows development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60