microsoft/Terminal

Schema does not allow actions without arguments in verbose form

Open

#11,332 opened on Sep 25, 2021

View on GitHub
 (7 comments) (1 reaction) (0 assignees)C++ (3,212 forks)batch import
Area-SchemaHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

No response

Steps to reproduce

Bind any 'shortcut action' using the following syntax:

{
  "command": {
    "action": "toggleAlwaysOnTop" // Most of the toggle actions qualify
  },
  "keys": "ctrl+alt+shift+§" // Any key combination
}

Expected Behavior

The schema should allow this, it's a working syntax.

Actual Behavior

It's considered invalid, with two problems:

  • Missing property "delta". Arguments corresponding to an Adjust Font Size Action

  • String does not match the pattern of "adjustFontSize".

Contributor guide

Research direction
Inspect the JSON schema file for terminal settings (likely in `src/cascadia/TerminalSettings/`). Locate the definition for actions and ensure the schema allows the verbose form without required arguments for actions like `toggleAlwaysOnTop`. Validate that the schema correctly marks optional properties as not required when the action type does not need them.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJSON Schema
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60