microsoft/Terminal

#7422 may have regressed - click on the top pixel of a tab when maximized

Open

#11,309 opened on Sep 22, 2021

View on GitHub
 (16 comments) (8 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugNeeds-ReproNeeds-Tag-FixPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

From discussion on a0670cb6b3e57dde525af1a04563e94ce80b5390

Interestingly, the compensation for GH #10746 might have caused 10746 to stop functioning by pushing the application body down one more pixel. I can't get the tab bar hit targets at the top of the screen when maximized to work any longer.

@DHowett If you've got a repro for that, can you fix that again? I checked out this PR when it was first opened to make sure that one was still fixed, but I guess I didn't have my monitors in the very peculiar config that repro'd #7422 in the first place.

This might also be the #11294 issue, but unlikely Dustin had the MUX commit at the time.

This also applies to the new tab dropdown combo button.

Contributor guide

Research direction
Investigate the pixel compensation logic changes between commits a0670cb and current HEAD, focusing on the tab bar hit testing when maximized. Check the MUX commit history for similar issues.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30