microsoft/Terminal

Quake mode does not consider vertical taskbar width

Open

#10,999 opened on Aug 21, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-WindowingHelp WantedIssue-BugNeeds-Tag-FixPriority-2Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version (or Windows build number)

10.0.19042.1165, 1.9.1942.0

Other Software

No response

Steps to reproduce

  1. Make sure you have at least one monitor with a vertical task bar.
  2. Open a Quake mode window on the monitor with the vertical task bar.

Expected Behavior

The Quake mode window should not be partially hidden behind the vertical task bar. It should recognize a vertical task bar is used and resize and reposition accordingly.

Actual Behavior

One side of the terminal looks cut off by the sidebar and it seeems to be positioned behind the task bar.

screenshot of the current behavior

Contributor guide

Research direction
Investigate how Quake mode window positioning interacts with the taskbar. Check Windows API for monitor information and taskbar rectangle. Possibly adjust the window rectangle to account for a vertical taskbar.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60