microsoft/Terminal

Suppress cursor blinking when text is actively being printed

Open

#1,087 opened on May 31, 2019

View on GitHub
 (7 comments) (4 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-RenderingHelp WantedIssue-TaskPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Here's an edge case I didn't cover in #686 - though it might warrant its own issue anyway.

Environment

Windows build number: 10.0.18362.145
Windows Terminal version (if applicable): commit 71e19cd82528d66a0a7867cbed85990cfc1685f1

Any other software?

Steps to reproduce

Print a lot of text to the console. This is especially apparent with progress bars that require backspace characters.

Actual behavior

The cursor continues to blink, or if the cursor blinking is turned off it stays on. This leads to some weird behaviour:

2019-05-31_17-20-01 2019-05-31_17-27-22

Expected behavior

I'm thinking the cursor should automatically hide when printing text. I've seen this done in a few other terminal programs.

Contributor guide

Research direction
Investigate the cursor blinking logic in the console host. Specifically, check where cursor visibility is toggled and ensure it is hidden during active text output.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65