microsoft/Terminal

`Pane::_FindFocusAndNeighbor` can probably be simpler

Open

#10,748 opened on Jul 21, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

If we view this problem from the point of the focused pane, what this function (and the other) do is basically:

  • move to the parent node
  • check if the other child node - the one the focused pane doesn't belong to - is in the direction we want to move the pane to
    • if yes: swap panes
    • if no: continue with the parent node

Is that correct? If my understanding is correct, I believe we can simplify this code after it has been merged.

Originally posted by @lhecker in https://github.com/microsoft/terminal/pull/10638#discussion_r674151375

Contributor guide

Research direction
Examine the function `Pane:: FindFocusAndNeighbor` and the referenced PR #10638 discussion to understand the proposed simplification. Trace the logic of moving to parent and checking sibling panes.
Tech stack
None
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows Terminal internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30