microsoft/Terminal

Memory leak and other issues when saving settings

Open

#10,609 opened on Jul 11, 2021

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsUIExternal-Blocked-WinUI3Help WantedIssue-BugPriority-1Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version (or Windows build number)

1.8.1521.0 (also observed on source build 2021-07-11)

Other Software

No response

Steps to reproduce

Open the settings dialog and spam click save. No option needs to be changed.

Video: 13 seconds in, the settings could not be reloaded from file (not sure if it is not loading or file corruption). https://user-images.githubusercontent.com/2277504/125179830-a31f3a00-e1f2-11eb-8b6f-6f6aa07896c5.mp4

Expected Behavior

Memory stays roughly the same, settings file can be loaded after saving, main UI does not extend past its borders.

Actual Behavior

Memory grows and is not reclaimed, settings file can sometimes not be loaded after saving, UI grows past its borders during reloading.

(Second and third only discovered after deciding to record a video for the memory leak)

Not sure if you want separate tracking issues for these, let me know.

Contributor guide

Research direction
Investigate the settings saving code path, focusing on memory allocation and deallocation. Use memory profiling tools like Valgrind or Windows Performance Analyzer to identify leaks. Also check for UI state corruption during rapid saves.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Windows Terminal internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30