microsoft/Terminal

`WriteCharsLegacy` performance issues caused by `NotifyConsoleUpdateSimpleEvent`

Open

#10,528 opened on Jun 29, 2021

View on GitHub
 (19 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-PerformanceHelp WantedIssue-TaskProduct-Conhost

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

I know this is a issue a long time ago, but haven't got the chance to talk about it.

This is typical WPR trace of OpenConsole with output-heavy programs.

image

Proposed technical implementation details (optional)

Perhaps throttling the event?

Contributor guide

Research direction
Analyze the WPR trace to identify the bottleneck caused by NotifyConsoleUpdateSimpleEvent and implement a throttling mechanism.
Tech stack
cpp
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Performance Profiling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40