microsoft/Terminal

DxRenderer should eat "concealed" text

Open

#10,511 opened on Jun 24, 2021

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)C++ (9,275 forks)batch import
Area-RenderingHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (103,173 stars)
PR merge metrics
 (PR metrics pending)

Description

Description of the new feature/enhancement

Invisible text is generally rendered as text with a foreground color equal to the background color. This can be repro'd as a part of https://github.com/jdebp/terminal-tests/tree/master/PowerShell).

This makes it not look invisible, however, because we apply the acrylic texture to the background, but not the foreground.

Proposed technical implementation details (optional)

Just make the renderer not render the invisible text. Ignore it completely.

Contributor guide

Research direction
Identify where the renderer draws text and add a check to skip rendering when text is concealed (foreground color equals background color).
Tech stack
cpp
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70