microsoft/Terminal

Find dialog (Ctrl+Shift+F), center the found string vertically

Open

#10,474 opened on Jun 21, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C++ (3,212 forks)batch import
Area-TerminalControlHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

When the find dialog is used, center the found string vertically in the terminal.

Proposed technical implementation details (optional)

I'm often interested in the few lines before the search string and sometimes the found string is behind the dialog itself. Centering it vertically would help in both cases.

Contributor guide

Research direction
Locate the find dialog implementation in the Windows Terminal codebase, understand how the matched text is scrolled into view, and modify the logic to center the matched string vertically within the terminal pane.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows Terminal development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65