microsoft/Terminal

Using `--window` in a `wt` action should do what you'd expect

Open

#10,146 opened on May 21, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CmdPalArea-RemotingHelp WantedIssue-TaskNeeds-Tag-FixProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

(from 1:1)

right now, TerminalPage::_HandleExecuteCommandline/TerminalPage::ConvertExecuteCommandlineToActions just tries to get the actions from the commandline, and tries to execute them. It would be really neat if we could determine that --window _quake was passed in that commandline, and toss the actions to the window you'd expect.

If there's no provided --window, then just execute the commandline in the current window. Otherwise, send the commandline to the monarch, and let them deal with it.

That would mean the command palette could get this functionality for commandline mode as well.

Contributor guide

Research direction
Investigate how TerminalPage:: HandleExecuteCommandline parses command line arguments and how the monarch dispatches actions to windows. Trace the handling of window flag and implement routing to the appropriate window.
Tech stack
cpp
Domain
desktopcli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40