microsoft/Terminal

Retro Terminal Effect looks bad with 125% screen scaling

Open

#10,132 opened on May 19, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-RenderingHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows Terminal version (or Windows build number)

1.7.1033.0

Other Software

No response

Steps to reproduce

The Retro Terminal Effect looks very nice with 100% screen scaling (selected in Windows Screen settings), but looks a little bit off when screen scaling is set to 125% (which is the default on my 1920*1080 laptop screen). With 100% screen scaling, the "scan lines" look evenly distributed, but they do not with 125% scaling. I'm attaching screenshots with both scaling factors in the "Expected behavior" and "Actual behavior" sections for comparison.

Expected Behavior

The expected behavior would be evenly distributed scan lines at any screen scaling setting, as seen on this screenshot at 100% scaling: 100 percent scaling

Actual Behavior

The scan lines look uneven at 125% screen scaling, as seen on this screenshot: 125 percent scaling

Contributor guide

Research direction
Investigate the retro terminal effect rendering code, specifically how scan lines are drawn and how they adapt to different display scaling factors. Look for any hard coded pixel values that might not account for scaling.
Tech stack
cpp
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75