microsoft/SynapseML

UDFtransformer should not extend HasInputCol and HasInputCols

Open

#243 opened on Feb 13, 2018

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Scala (5,228 stars) (861 forks)batch import
buggood first issuehelp wanted

Description

This is a bit confusing and will cause complications if both parameters are independently set. Try extending the latter and adding custom setters in scala and py side

Contributor guide

Tech stack
scala
Domain
machine learning
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ScalaSpark MLSynapseML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue suggests that UDFTransformer currently extends both HasInputCol and HasInputCols, which can cause confusion if both parameters are set independently. The fix should extend only HasInputCols and add custom setters for inputCol and inputCols on the Scala side, with corresponding updates on the Python side. Look at the current UDFTransformer source code in the SynapseML repository to understand the inheritance chain and implement the change.
UDFtransformer should not extend HasInputCol and HasInputCols · microsoft/SynapseML#243 | Good First Issue