remove debug-mode finalizer check

Open Beginner friendly
#16 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp
Domain
backend

Research direction

Locate the lock-handle finalizer check that panics for undisposed handles and review how the library is packaged for NuGet. Remove the debug-mode finalizer behavior without changing normal lock handling, and verify that the package no longer requires a debug build to avoid this panic.

Written by the indexing model from the issue text.

Description

the initial version of this code inherits the behavior of panicking if we finalize an undisposed lock handle. that was intended to help us find deadlocks, and it worked okay when this code lived inside one of our repos, but it doesn't work as a package since consumers would need to be using a debug build of the library itself.

a roslyn analyzer is the right way to provide guarantees about locks always being released properly. the finalizer approach is never going to work in a stand-alone library consumed via nuget, so it should be removed.

Dominant language
C#
Stars
9
Forks
1
Avg merge
13d 22h
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/StateKeeper

All issues in microsoft/StateKeeper

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.