microsoft/RoslynClrHeapAllocationAnalyzer

Closure capture of "this" points to the method node, instead pick class decl node

Open

#12 opened on May 3, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (63 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (654 stars)
PR merge metrics
 (PR metrics pending)

Description

When a closure captures the this parameter, we lazily just point to the method declaration syntax node, but we really should point to the class/struct declaration node.

If the class is a partial class, then we should point to the class declaration node in the current file.

Contributor guide

Research direction
Inspect the closure capture logic in the analyzer to find where 'this' is captured. Instead of pointing to the method node, modify it to point to the class or struct declaration node. For partial classes, use the class declaration in the current file.
Tech stack
csharp
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Roslyn
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60