microsoft/PowerToys

[Run] Refactor Plugins UpdateIconPath

Open

#8,134 opened on Nov 19, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C# (7,978 forks)batch import
Help WantedIssue-RefactoringProduct-PowerToys Run

Repository metrics

Stars
 (133,154 stars)
PR merge metrics
 (Avg merge 14d 20h) (117 merged PRs in 30d)

Description

"Abstracted out as I think most plugins have to do this. This way we're consistent."

Originally posted by @crutkas in https://github.com/microsoft/PowerToys/pull/8062#discussion_r525622227

https://github.com/microsoft/PowerToys/blob/9144123f32a6b938ddd256bc459e1acf93d5c906/src/modules/launcher/Plugins/Microsoft.Plugin.Folder/Main.cs#L89-L92

https://github.com/microsoft/PowerToys/blob/9144123f32a6b938ddd256bc459e1acf93d5c906/src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Main.cs#L280-L290

https://github.com/microsoft/PowerToys/blob/9144123f32a6b938ddd256bc459e1acf93d5c906/src/modules/launcher/Plugins/Microsoft.Plugin.Uri/Main.cs#L159-L169

Contributor guide

Research direction
Examine the referenced code snippets to identify the common UpdateIconPath pattern. Create a shared utility method to replace the duplicated implementations across plugins.
Tech stack
csharp
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70