microsoft/PowerToys

Replace Thread.Sleep with task.Delay

Open

#7,427 opened on Oct 20, 2020

View on GitHub
 (2 comments) (2 reactions) (0 assignees)C# (7,978 forks)batch import
Area-QualityArea-TestsCost-SmallHelp WantedProduct-Color PickerProduct-PowerToys Run

Repository metrics

Stars
 (133,154 stars)
PR merge metrics
 (Avg merge 14d 20h) (117 merged PRs in 30d)

Description

Performance Improvement of PT Run

Similar to PR #7401, replacing Thread.Sleep with Task.Delay throughout the codebase would improve the performance of PT Run as Thread.Sleep blocks the thread that it is called on whereas Task.Delay uses a timer instead and schedules a thread to resume work after the interval has passed. This does not block the thread.

Contributor guide

Research direction
Search for all occurrences of Thread.Sleep in the codebase and replace with await Task.Delay, ensuring that the containing method is marked as async and the Task.Delay is awaited. Refer to PR #7401 for a similar example.
Tech stack
csharp
Domain
desktop
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80