microsoft/PowerToys

[PT Run] Folder plugin: Add localization

Open

#23,666 opened on Jan 30, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (7,978 forks)batch import
Help WantedIdea-EnhancementProduct-PowerToys RunRun-Plugin

Repository metrics

Stars
 (133,154 stars)
PR merge metrics
 (Avg merge 14d 20h) (117 merged PRs in 30d)

Description

For the plugins "Programs" and "Windows Search" we added localization now. For Folder plugin this is not done yet.

The localization should be added using the two methods from ShellLocalization helper in Wox.Plugin.Common.

Requirements for search:

  • Searching by localized name.
  • Searching by original name.

Requirements for results:

  • Localized file/folder name as title.
  • Localized file/folder path in sub title.
  • Tool tip showing original and localized path.

Things to take care about:

  • For opening files/folders in Explorer, CMD, ... we have to use the original file name. The localized version will fail with access denied error.
  • The helper class should be initialized as static variable in the main method of the plugin to benefit from its cache feature.

Contributor guide

Research direction
Examine the Folder plugin code and the existing localization pattern from Programs and Windows Search plugins. Use the ShellLocalization helper from Wox.Plugin.Common to implement localized search and display.
Tech stack
csharp
Domain
localizationdesktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75