microsoft/PowerToys

[File Locksmith] Request confirmation on closing processes

Open

#21,807 opened on Nov 6, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (7,978 forks)batch import
Area-User InterfaceHelp WantedIdea-EnhancementProduct-File Locksmith

Repository metrics

Stars
 (133,154 stars)
PR merge metrics
 (Avg merge 14d 20h) (117 merged PRs in 30d)

Description

Add a warning/confirmation message that is shown when you close the process owned by a different user or the system/nt-service, ... user? Originally posted by @htcfreek in https://github.com/microsoft/PowerToys/issues/21688#issuecomment-1302507429

The warning/confirmation message should prevent users from losing data or crashing the system.

We can have the following message cases:

  • Same user: Are you sure to close the process <name>?
  • Different user: Are you sure to close the process _name_? Attention, it is owned by the user <user name>.
  • System process (User=System/Service/...): Are you sure to close the process <name>? ATTENTION, IT IS A CRITICAL SYSTEM PROCESS!

We can also add a setting to warn only for processes that are critical or belongs to an other user.

Contributor guide

Research direction
Examine the File Locksmith module in PowerToys, locate the process termination code, and add a confirmation dialog that checks the process owner (same user, different user, or system) and displays appropriate warnings.
Tech stack
csharp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75